Add publishMesh example#154
Conversation
nbbrooks
commented
Jun 2, 2020
nbbrooks
commented
- Add .gitattributes and chess piece .stl files
- Add .gitattributes and chess piece .stl files
|
I actually need this for one of our projects right now! Let's try to get it merged. Edit - oh, I need it for ROS1. Well, this is still a nice example to have |
| ) | ||
|
|
||
| # Install shared resources | ||
| install(DIRECTORY launch DESTINATION share/${PROJECT_NAME}) |
There was a problem hiding this comment.
Too many spaces between launch and DESTINATION
There was a problem hiding this comment.
I think the best thing would be to put DESTINATION on a new line, like at L205
| step = 0.2; | ||
| const std::array<double, 6> thetas = { 0.0, 0.0, 0.0, 0.0, 0.0, 0.0 }; | ||
| const std::array<std::string, 6> meshes = { | ||
| "pawn", "knight", "bishop", "rook", "queen", "king" |
There was a problem hiding this comment.
I'm not a huge fan of uploading so many STL's, I think one would have been fine. But I guess it's OK
| visual_tools_->publishMesh(pose1 * Eigen::AngleAxisd(thetas[i], Eigen::Vector3d::UnitZ()), | ||
| "package://rviz_visual_tools/meshes/" + meshes[i] + ".stl", | ||
| mesh_colors[i], scales[i]); | ||
| if (i == 0.0) |
There was a problem hiding this comment.
I suppose you could use (!i) here
|
Also, delete the comment at L596 of rviz_visual_tools_demo.cpp |
tylerjw
left a comment
tylerjw
left a comment
There was a problem hiding this comment.
This is failing for clang-tidy reasons. Please look at the output in travis and apply that diff. If those failures are unrelated to this PR, please make a new PR with those changes and then rebase this one after that one is merged.
3 participants
