Debug TimestepDidNotMatch test#49
Closed
AndyZe wants to merge 1 commit intoremove_excessive_deriv_calcsfrom
Closed
Debug TimestepDidNotMatch test#49AndyZe wants to merge 1 commit intoremove_excessive_deriv_calcsfrom
AndyZe wants to merge 1 commit intoremove_excessive_deriv_calcsfrom
Conversation
AndyZe
force-pushed
the
debug_TimestepDidNotMatch_test
branch
from
db67ba8 to
ed73955
Compare
AndyZe
changed the title
Contributor
Author
|
superseded by #58 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was moving forward this many elements in downSample():
new_positions[count] = (*position_vector)[count * num_elements_to_skip];The new version is:
new_positions[count] = (*position_vector)[last_element_pulled_from_beginning + num_elements_to_skip];I realize this calculation is made repeatedly and could be optimized, but I left it to help readability. Willing to change that, though:
last_element_pulled_from_beginning + num_elements_to_skip