Update Readme that we are not using Google style#60
Closed
Conversation
Member
|
If this is the case, I don't understand why this PR is failing the clang job |
nbbrooks
reviewed
Jul 15, 2020
Member
|
This is failing clang because the "ERROR_CODE_MAP" is formatted nicely, but not according to clang. I'd just block it with edit: Oh yeah...ctdc doesn't make this modification so I wanted to figure out why CI was modifying it |
Contributor
|
The CI failures where |
Co-authored-by: Nathan Brooks <nathanbrooks@picknik.ai>
Contributor
Author
|
This is outdated since we use pre-commit for formatting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.