Skip to content

Update Readme that we are not using Google style#60

Closed
AndyZe wants to merge 4 commits intomasterfrom
andyz/update_readme_re_clang
Closed

Update Readme that we are not using Google style#60
AndyZe wants to merge 4 commits intomasterfrom
andyz/update_readme_re_clang

Conversation

@AndyZe
Copy link
Contributor

@AndyZe AndyZe commented Jul 13, 2020

No description provided.

@AndyZe AndyZe requested a review from nbbrooks July 13, 2020 17:03
@nbbrooks
Copy link
Member

If this is the case, I don't understand why this PR is failing the clang job

@nbbrooks
Copy link
Member

nbbrooks commented Sep 18, 2020

This is failing clang because the "ERROR_CODE_MAP" is formatted nicely, but not according to clang. I'd just block it with
// clang-format off
...
// clang-format on

edit: Oh yeah...ctdc doesn't make this modification so I wanted to figure out why CI was modifying it

@zultron
Copy link
Contributor

zultron commented Sep 20, 2020

The CI failures where clang-format broke up strings in that nasty way (unfold the "Running clang-format" part of the log), I fixed in commit e12fb23 over in #63. I also put in a PR over at PickNikRobotics/roscpp_code_format#14 so this problem doesn't propagate further.

@AndyZe
Copy link
Contributor Author

AndyZe commented Jan 31, 2022

This is outdated since we use pre-commit for formatting

@AndyZe AndyZe closed this Jan 31, 2022
@AndyZe AndyZe deleted the andyz/update_readme_re_clang branch January 31, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants