single_joint_generator: Remove trailing _ from function parameter#65
Merged
AndyZe merged 1 commit intoPickNikRobotics:andyz/squashed_improvementsfrom Sep 23, 2020
Conversation
Contributor
|
good catch, thanks |
AndyZe
approved these changes
Sep 21, 2020
Contributor
AndyZe
left a comment
AndyZe
left a comment
There was a problem hiding this comment.
will merge if/when CI passes
Contributor
Author
|
CI won't pass ATM since it's based on the current |
Contributor
|
oh, got it. Well, I'll merge if everything passes except NoisyStreaming |
Contributor
|
CI caught this error. Should be |
zultron
force-pushed
the
zultron/2020-09-21-parameter-name-tweak
branch
from
c548101 to
9d2e0c3
Compare
Contributor
Author
Thanks for catching this. PR updated, and tests are passing (other than |
AndyZe
approved these changes
Sep 23, 2020
AndyZe
pushed a commit
that referenced
this pull request
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixup for 7c937ad
@AndyZe I'm guessing this was unintentional; if not, just close the PR without merging. Thanks!