Skip to content

Update review.yml #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PierreGode merged 2 commits into from
Dec 10, 2024
Merged

Update review.yml #90

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e203243
Update review.yml
PierreGode Dec 10, 2024
c76ee33
Update review.yml
PierreGode Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ jobs:
diff_url = event['pull_request']['url'] + "/files"
pr_files = requests.get(diff_url, headers=headers).json()

diff_text = ""
inline_comments = [] # Collect inline comments to post
diff_text = ""

for fdata in pr_files:
filename = fdata['filename']
Expand Down Expand Up @@ -107,7 +107,7 @@ jobs:
headers={'Authorization': f'token {token}', 'Accept': 'application/vnd.github.v3+json'},
json=review_data)
review_response.raise_for_status()
print("Review comments posted successfully.")
print("Inline review comments posted successfully.")
else:
print("No critical issues found in the code.")

Expand Down
Loading