feat(dockerfiles/cd/builders/tidb-dashboard): update Node.js and pnpm versions in TiDB Dashboard Dockerfiles #869
Conversation
versions in TiDB Dashboard Dockerfiles Update Node.js from 16.x/18.x to 22.x and pnpm from 7.30.5/9.7.0 to 9.12.2 Update Skaffold templates to include Node.js version in tags
Summary of ChangesHello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing the build environment for TiDB Dashboard Docker images by upgrading the Node.js and pnpm versions. This update ensures that the project leverages the latest features and security patches from these critical dependencies, while also updating the Skaffold configurations to accurately reflect these changes in the image tagging scheme. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates Node.js and pnpm versions in the TiDB Dashboard Dockerfiles and corresponding Skaffold configurations. The changes are generally good, especially combining multiple RUN commands into one to reduce Docker image layers. I've added a couple of suggestions to further optimize the image size by clearing the npm cache after installation.
| RUN curl -fsSL https://rpm.nodesource.com/setup_22.x | bash - && \ | ||
| yum -y install nodejs && yum clean all && \ | ||
| npm install -g pnpm@9.12.2 |
There was a problem hiding this comment.
To optimize the Docker image size, it's a good practice to clean the npm cache after installing packages. This can be done by adding npm cache clean --force to the RUN instruction.
RUN curl -fsSL https://rpm.nodesource.com/setup_22.x | bash - && \
yum -y install nodejs && yum clean all && \
npm install -g pnpm@9.12.2 && npm cache clean --force
| RUN curl -fsSL https://rpm.nodesource.com/setup_22.x | bash - && \ | ||
| yum -y install nodejs && yum clean all && \ | ||
| npm install -g pnpm@9.12.2 |
There was a problem hiding this comment.
To optimize the Docker image size, it's a good practice to clean the npm cache after installing packages. This can be done by adding npm cache clean --force to the RUN instruction.
RUN curl -fsSL https://rpm.nodesource.com/setup_22.x | bash - && \
yum -y install nodejs && yum clean all && \
npm install -g pnpm@9.12.2 && npm cache clean --force
Update Node.js from 16.x/18.x to 22.x and pnpm from 7.30.5/9.7.0 to
9.12.2 Update Skaffold templates to include Node.js version in tags