chore(packages): lower builder image threshold to 1.6.5 to use go1.25 for tidb-operator

[wuhuizuo]

No description provided.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary
This PR updates the version threshold in the package template to lower the builder image switch from "1.7.0-0" to "1.6.5-0". This change makes the builder use Go 1.25 starting from version 1.6.5 instead of 1.7.0. The modification is limited and well-scoped in the packages.yaml.tmpl file, adjusting semver constraints accordingly. The change appears straightforward and correctly formatted.

---

Code Improvements

• File: packages/packages.yaml.tmpl lines 1558-1566
  • The semver constraint change is correct logically, but the two constraints:

    ">= 1.6.5-0"
    ">= 1.6.0-0, < 1.6.5-0"

    require careful validation that no versions fall through the cracks or overlap ambiguously.
  • Suggestion: Consider adding comments or a note near the constraints to clarify the version ranges and the corresponding builder images to assist future maintainers.

---

Best Practices

• File: packages/packages.yaml.tmpl lines 1558-1566

  • The template currently lacks inline comments explaining the rationale behind the version thresholds and the Go versions associated with each builder image.
  • Suggestion: Add brief comments like:

    # Use Go 1.25 builder image for versions >= 1.6.5
    # Use Go 1.23 builder image for versions >= 1.6.0 and < 1.6.5

    This improves maintainability and clarity for future updates.

• Testing Coverage

  • Since this is a semver-based conditional template, ensure that the change is covered by tests that verify correct builder image selection for versions around the 1.6.5 boundary.
  • Suggestion: If not already present, add or update unit tests or integration tests that exercise builder image selection for versions 1.6.4, 1.6.5, and 1.7.0 to catch regressions.

---

No critical issues detected given the scope and nature of the change. The PR is a low-risk version threshold update but would benefit from added documentation and testing confirmation.

[wuhuizuo]

/approve

[gemini-code-assist]

Summary of Changes

Hello @wuhuizuo, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the version constraints within the packages.yaml.tmpl file to modify which Go builder image is used for specific tidb-operator release versions. The change aims to enable earlier adoption of the Go 1.25 build environment for tidb-operator by adjusting the semantic versioning checks.

Highlights

• Builder Image Version Threshold Update: The minimum version threshold for tidb-operator to use the go1.25 builder image has been lowered from 1.7.0-0 to 1.6.5-0. This allows tidb-operator versions 1.6.5-0 and above to utilize the newer Go 1.25 build environment.
• Go 1.23 Builder Image Range Adjustment: Correspondingly, the upper bound for tidb-operator versions using the go1.23 builder image has been adjusted from < 1.7.0-0 to < 1.6.5-0. This ensures a clear transition between the Go 1.23 and Go 1.25 build environments based on the tidb-operator version.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [wuhuizuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Code Review

The pull request effectively updates the version constraints for the tidb-operator builder images in packages/packages.yaml.tmpl. It correctly lowers the minimum version for using the go1.25 builder image to 1.6.5-0 and adjusts the upper bound for the go1.23 builder image to maintain consistent versioning logic. This change aligns with the objective of using go1.25 for tidb-operator for versions 1.6.5 and above.