-
Notifications
You must be signed in to change notification settings - Fork 110
chore(jobs,pipelines): remove TiDB periodic integration test pipeline #4059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
and related files This commit removes the entire periodic integration test pipeline for TiDB, including: - The Jenkins job definition file - The main pipeline script - The Kubernetes pod template YAML file The pipeline was used for regular integration testing of TiDB components with TiKV and PD.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @wuhuizuo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the CI/CD infrastructure by completely decommissioning and removing the periodic integration test pipeline for TiDB. The change focuses on cleaning up and eliminating components that are no longer necessary, thereby simplifying the overall CI setup and reducing maintenance overhead. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have already done a preliminary review for you, and I hope to help you do a better job.
Summary:
This pull request removes the periodic integration test pipeline for TiDB, along with its associated Jenkins job definition, pipeline script, and Kubernetes pod template YAML file. The approach is straightforward: all related files are deleted entirely. The removal is well-executed, with no lingering references or incomplete deletions in the provided diff. Overall, the PR adheres to the intended goal of eliminating unused infrastructure cleanly.
Critical Issues:
No critical issues were found in this PR. All files related to the periodic integration test pipeline are fully removed, and no broken functionality or security concerns are introduced.
Code Improvements:
- Evaluate dependencies and references:
- Ensure that no other jobs or pipelines depend on the removed files, particularly the Groovy scripts and YAML pod templates. While the PR cleans up its targeted files, double-checking for orphaned dependencies or indirect references in other parts of the codebase is recommended.
Best Practices:
-
Documentation Updates:
- File Reference: If the removed files are referenced in any documentation (e.g., internal wiki, README files, or operational guides), update or remove those references to reflect the pipeline's removal.
- Change Log: Consider adding a note in the project's changelog about the removal of this pipeline to inform stakeholders of the deprecation.
-
Testing Coverage:
- Verification: Confirm via CI or manual testing that no unexpected errors arise in the system due to the pipeline removal. For example, ensure that Jenkins job configurations and Kubernetes deployments are not affected.
Suggested Actions:
- Conduct a search across the repository for any references to the deleted files (
periodics_integration_test.groovy,pod-periodics_integration_test.yaml) and remove or update them. - Validate that removing the pipeline does not break any dependent workflows or scripts (e.g., other pipelines that call this one).
- Update documentation and changelog to reflect the pipeline's removal.
No further issues were identified, and the PR is otherwise ready for merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes the TiDB periodic integration test pipeline by deleting the Jenkins job definition, the pipeline script, and the associated Kubernetes pod template. The changes are straightforward and achieve the stated goal. I have added one comment suggesting a potential cleanup of orphaned scripts that were used by this pipeline.
I am having trouble creating individual review comments. Click here to see my feedback.
pipelines/pingcap/tidb/latest/periodics_integration_test.groovy (114-185)
This Checks stage executes several scripts, such as integrationtest_with_tikv.sh and run_real_tikv_tests.sh. With the removal of this pipeline, these scripts may now be orphaned. If they are not used by other CI jobs, please consider removing them as well to prevent dead code in the repository.
|
/hold Only can merge it when we have finished the downloading migration from fileserver to OCI artifacts. |
and related files
This commit removes the entire periodic integration test pipeline for TiDB, including:
The pipeline was used for regular integration testing of TiDB components with TiKV and PD.