Configure menu buttons to show traditional submenus without sliding#2131
Open
cameronwhite wants to merge 1 commit intomasterfrom
Open
Configure menu buttons to show traditional submenus without sliding#2131cameronwhite wants to merge 1 commit intomasterfrom
cameronwhite wants to merge 1 commit intomasterfrom
Conversation
Contributor
|
Maybe we could reuse the CreateMenuButton function to, instead of creating each menu entry from MenuModel directly, use the Gtk.PopoverMenu.add_child method to create each entry (with icons, shortcuts and even tooltips, if we need to), and then use a Gtk.PopoverBin over a Gtk.Box when we have submenus. This allows greater control without making things too complex. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier to browse through nested menus like the effects without annoying sliding and extra clicks to go back. The only minor annoyance is that the menus sometimes pop out to the left side, depending on available space if Pinta's window is near the right edge, but overall it feels nicer IMO