Skip to content

Conversation

@TheBestMoshe
Copy link
Contributor

@TheBestMoshe TheBestMoshe commented Dec 5, 2025

Pipedream JWT access tokens do not have the project id encoded in it. It should use the project id passed in during client config

Summary by CodeRabbit

  • Bug Fixes

    • Token-based authentication now preserves the configured project ID (from options or environment) during initialization instead of clearing it.
  • Chores

    • Package and SDK version bumped to 2.3.2.

✏️ Tip: You can customize this high-level summary in your review settings.

Pipedream JWT access tokens do not have the project id encoded in it. It should use the project id passed in during client config
@coderabbitai
Copy link

coderabbitai bot commented Dec 5, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Removes an explicit override of projectId to an empty string when a tokenProvider is supplied, and bumps the package and SDK version from 2.3.1 to 2.3.2.

Changes

Cohort / File(s) Change Summary
Token-based authentication initialization
src/wrapper/Pipedream.ts
Removed the line that forced projectId to "" when tokenProvider is provided, so projectId from options or environment is preserved.
Version bump / package manifest
package.json, src/version.ts
Updated package version and exported SDK_VERSION constant from 2.3.1 to 2.3.2.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Inspect src/wrapper/Pipedream.ts to ensure token-based auth still initializes correctly when projectId is supplied via opts or environment.
  • Confirm no downstream assumptions rely on projectId having been cleared in the token-provider branch.
  • Verify version bump in package.json and src/version.ts are consistent.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the projectId override in the tokenProvider initialization path, which directly matches the code modification shown in the raw summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e00cba7 and 04d17f2.

📒 Files selected for processing (2)
  • package.json (1 hunks)
  • src/version.ts (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@jverce jverce merged commit 50c2179 into main Dec 5, 2025
3 of 4 checks passed
@jverce jverce deleted the fix-project-id-override branch December 5, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants