-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Eng 8702,eng 8703,eng 8704 #18072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eng 8702,eng 8703,eng 8704 #18072
Conversation
@HarshGautam7101 is attempting to deploy a commit to the Pipedreamers Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
WalkthroughAdds centralized endpoint/constants and utilities, refactors the Token Metrics app to a generic API client with standardized error handling, and rewrites README. Introduces numerous new action modules and updates existing ones to use shared utilities (buildParams, generateFilterSummary) and new endpoint wrappers with consistent pagination and summaries. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Action
participant Utils as Utils (buildParams / generateFilterSummary)
participant App as TokenMetrics App
participant API as Token Metrics API
User->>Action: Invoke action with props
Action->>Utils: buildParams(props, endpoint.filters)
Action->>App: makeApiCall(endpoint, params)
App->>API: GET /v2/<endpoint>?params
API-->>App: Response / Error
alt Success
App-->>Action: Data
Action->>Utils: generateFilterSummary(props, filters)
Action-->>User: Return data (+ $summary)
else Error
App-->>Action: Error
Action-->>User: Throw "Token Metrics API Error (status): message"
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45–60 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified. |
Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:
|
…Gautam7101/token-metrics-api-pipedream into ENG-8702,ENG-8703,ENG-8704
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, thanks for your contribution! I see you've added a lot of components, that is greatly appreciated.
I've commented on a few general changes that need to be made across most or all of the components, before this is ready to be merged. Let me know if you need any assistance
components/token_metrics/actions/get-ai-reports/get-ai-reports.mjs
Outdated
Show resolved
Hide resolved
components/token_metrics/actions/get-ai-reports/get-ai-reports.mjs
Outdated
Show resolved
Hide resolved
components/token_metrics/actions/get-ai-reports/get-ai-reports.mjs
Outdated
Show resolved
Hide resolved
components/token_metrics/actions/get-ai-reports/get-ai-reports.mjs
Outdated
Show resolved
Hide resolved
components/token_metrics/actions/get-daily-ohlcv/get-daily-ohlcv.mjs
Outdated
Show resolved
Hide resolved
components/token_metrics/actions/get-moonshot-tokens/get-moonshot-tokens.mjs
Outdated
Show resolved
Hide resolved
components/token_metrics/actions/get-resistance-support/get-resistance-support.mjs
Outdated
Show resolved
Hide resolved
- Add markdown formatting to all example values with backticks - Highlight date formats (`YYYY-MM-DD`) in prop descriptions - Add `min: 1` validation to all page props across 19 action files - Remove verbose pagination descriptions in favor of built-in validation - Standardize prop definitions using `propDefinitions` from app file - Convert comma-separated string props to `string[]` type for better UX - Remove redundant `if ($ && $.export)` checks from all actions - Remove custom `try/catch` blocks to leverage Pipedream's native error handling - Clean up `handleApiError` utility function and related imports - Fix prop descriptions to use proper options instead of text descriptions - Update README.md to be more concise and professional per feedback This refactor improves code maintainability, user experience, and follows Pipedream component best practices for validation, error handling, and documentation formatting.
- Add markdown formatting to all example values with backticks - Highlight date formats (`YYYY-MM-DD`) in prop descriptions - Add `min: 1` validation to all page props across 19 action files - Remove verbose pagination descriptions in favor of built-in validation - Standardize prop definitions using `propDefinitions` from app file - Convert comma-separated string props to `string[]` type for better UX - Remove redundant `if ($ && $.export)` checks from all actions - Remove custom `try/catch` blocks to leverage Pipedream's native error handling - Clean up `handleApiError` utility function and related imports - Fix prop descriptions to use proper options instead of text descriptions - Update README.md to be more concise and professional per feedback This refactor improves code maintainability, user experience, and follows Pipedream component best practices for validation, error handling, and documentation formatting.
@GTFalcao I’ve implemented all the required changes, it should be good now. Can you please recheck? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're able, running pnpm install -r
and committing the pnpm-lock.yaml
file will ensure the PR checks run properly.
I left a few comments, but I'm moving the PR forward to be QA'd, as these comments do not impact functionality.
components/token_metrics/actions/get-market-metrics/get-market-metrics.mjs
Outdated
Show resolved
Hide resolved
Hi everyone, all test cases are passed! Ready for release! Test report |
- Remove unused generateEndpointProps function from utils.mjs - Update pnpm-lock.yaml to ensure PR checks run properly - Clean up code by removing dead code that was never imported or used
f0dd550
to
333c3eb
Compare
Commited |
components/token_metrics/actions/get-market-metrics/get-market-metrics.mjs
Outdated
Show resolved
Hide resolved
ESLint issues need to be adjusted before the PR can be merged:
|
…nent - Fix import formatting across all action files - Remove trailing whitespace from constants and other files - Add proper newline endings to package.json - Apply consistent spacing and formatting throughout - Improve code readability and maintain style consistency
@GTFalcao It's done ! |
WHY
Summary by CodeRabbit