Skip to content

Conversation

verhovsky
Copy link
Contributor

@verhovsky verhovsky commented Oct 3, 2025

https://www.npmjs.com/package/crypto is an empty module because

import crypto from "crypto";
// or more explicitly
import crypto from "node:crypto";

actually imports Node's builtin Crypto module, so there's no reason to install it.

On Node 19+ you don't even have to import it, crypto is already a global variable.

Summary by CodeRabbit

  • Chores
    • Removed an unnecessary "crypto" dependency across many integrations and the root package to streamline installations.
    • Reduced dependency surface and package footprint for improved reliability and security posture.
    • No user-facing behavior changes, API modifications, or functional changes were introduced.

@adolfo-pd adolfo-pd added the User submitted Submitted by a user label Oct 3, 2025
Copy link

vercel bot commented Oct 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
pipedream-docs-redirect-do-not-edit Ignored Ignored Oct 6, 2025 2:59pm

@pipedream-component-development
Copy link
Collaborator

Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.

@pipedream-component-development
Copy link
Collaborator

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

Copy link
Contributor

coderabbitai bot commented Oct 3, 2025

Walkthrough

Removed the "crypto" dependency from the root package.json and many component package.json files; one component removed its entire dependencies block. No source code, API, or control-flow changes are present.

Changes

Cohort / File(s) Summary of edits
Root manifest
package.json
Removed dependency entry: crypto.
Component manifests — crypto removed
components/brex_staging/package.json, components/cats/package.json, components/cisco_webex/package.json, components/clickup/package.json, components/clio/package.json, components/companycam/package.json, components/eversign/package.json, components/fidel_api/package.json, components/google_ads/package.json, components/google_cloud/package.json, components/help_scout/package.json, components/intercom/package.json, components/jotform/package.json, components/kontent_ai/package.json, components/mailersend/package.json, components/memberful/package.json, components/paradym/package.json, components/paymo/package.json, components/printify/package.json, components/productive_io/package.json, components/savvycal/package.json, components/signnow/package.json, components/ticket_tailor/package.json, components/trello/package.json, components/twitch/package.json, components/vercel_token_auth/package.json, components/woocommerce/package.json, components/zendesk/package.json, components/zoho_crm/package.json
Removed dependency entry: crypto. No other dependency or configuration changes noted.
Component manifest — dependencies block removed
components/superdocu/package.json
Removed crypto and the entire dependencies block; adjusted trailing commas/formatting.
Whitespace/file formatting
components/stackby/stackby.app.mjs
Added trailing newline at end-of-file; no functional change.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nibbled the vines where deps entwine,
Snipped crypto leaves from every line.
A garden lighter, paths now clear,
Fewer weeds for builds to fear.
Thump-thump! I bounce with tidy cheer—🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The description explains why the npm “crypto” package is unnecessary but does not follow the repository’s pull request template by omitting the required “## WHY” heading and its placement in the prescribed structure. Please update the PR description to include the “## WHY” section header from the repository template and move the explanation text beneath it to match the required format.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly and accurately describes the primary change of removing the redundant npm “crypto” package, making it clear to reviewers what this pull request does without unnecessary detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 71ca7fb and 10285ff.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • components/stackby/stackby.app.mjs (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • components/stackby/stackby.app.mjs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

GTFalcao
GTFalcao previously approved these changes Oct 3, 2025
Copy link
Collaborator

@GTFalcao GTFalcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Welcome aboard, @verhovsky

Will probably need to run npx pnpm install -r again though

@verhovsky
Copy link
Contributor Author

Thank you @GTFalcao! I re-ran it but nothing changed.

@GTFalcao
Copy link
Collaborator

GTFalcao commented Oct 4, 2025

Best to just merge w/ master to resolve the conflict then.

* upstream/master:
  Adding app scaffolding for stackby
  Airtop new components (PipedreamHQ#18637)
  Sinch - new components (PipedreamHQ#18635)
  Mintlify - new components (PipedreamHQ#18519)
  Linear App - updates and new components (PipedreamHQ#18606)
  Merging pull request PipedreamHQ#18622
  Adding app scaffolding for airtop
@GTFalcao GTFalcao merged commit f0ff38b into PipedreamHQ:master Oct 6, 2025
9 of 10 checks passed
@github-project-automation github-project-automation bot moved this from Ready for PR Review to Done in Component (Source and Action) Backlog Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User submitted Submitted by a user
Development

Successfully merging this pull request may close these issues.

4 participants