-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Gorgias - new components #19274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Gorgias - new components #19274
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
WalkthroughAdds new Gorgias ticket/tag/field/macro actions and corresponding app client methods, introduces dynamic ticket-field update props, and bumps package and multiple action/source versions across the Gorgias OAuth component. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Action as Tag Action (add/list/set)
participant App as Gorgias App Client
participant API as Gorgias API
User->>Action: invoke with ticketId (+ tagIds)
Action->>App: call addTicketTags/listTicketTags/setTicketTags({ ticketId, ... })
App->>API: HTTP POST/GET/PUT /tickets/{ticketId}/tags
API-->>App: response (tags/count)
App-->>Action: return response
Action->>Action: export summary (e.g., "Added X tags to ticket Y")
Action-->>User: return API response
sequenceDiagram
participant User
participant Action as update-ticket-field-values
participant App as Gorgias App Client
participant API as Gorgias API
User->>Action: invoke with ticketId and field props
Action->>App: listCustomFields()
App->>API: GET /custom-fields
API-->>App: custom field definitions
App-->>Action: return definitions
Action->>App: listTicketFieldValues({ ticketId })
App->>API: GET /tickets/{ticketId}/custom-fields
API-->>App: existing field values
App-->>Action: return existing values
Action->>Action: build payload (merge provided + existing, convert types)
Action->>App: updateTicketFieldValues({ ticketId, data })
App->>API: POST /tickets/{ticketId}/custom-fields
API-->>App: update response
App-->>Action: return response
Action->>Action: export summary
Action-->>User: return API response
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 2 inconclusive)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
luancazarine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @michelle0927, LGTM! Ready for QA!
|
Hello everyone, I have tested this PR and there're some test cases failed or needed improvement. Please check test reports below for more information:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
components/gorgias_oauth/actions/update-ticket-field-values/update-ticket-field-values.mjs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Lint Code Base
- GitHub Check: pnpm publish
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
Resolves #19170
Resolves #19169
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.