Add hierarchical domains and pipe namespacing (Phase 1) #671
Conversation
Introduce QualifiedRef as the centralized model for domain-qualified
reference parsing, replacing scattered .split(".")/rsplit(".") calls
across 8+ files. This enables hierarchical domains (e.g. "legal.contracts")
and domain-qualified pipe references (e.g. "scoring.compute_score"),
making pipes symmetric with the existing concept reference system.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afe1585ad5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # If it's a domain-qualified ref (e.g. "scoring.compute_score"), try the local code | ||
| if "." in pipe_code: | ||
| ref = QualifiedRef.parse(pipe_code) | ||
| return self.root.get(ref.local_code) |
There was a problem hiding this comment.
This lookup drops the qualified domain and resolves only by local_code, so a reference like wrong_domain.compute_score will still resolve to any loaded compute_score pipe instead of failing. Because controller dependency validation also uses get_required_pipe, this can silently route to the wrong pipe and hide misconfigured domain prefixes in production workflows.
Useful? React with 👍 / 👎.
| return pipe | ||
| # If it's a domain-qualified ref (e.g. "scoring.compute_score"), try the local code | ||
| if "." in pipe_code: | ||
| ref = QualifiedRef.parse(pipe_code) |
There was a problem hiding this comment.
get_optional_pipe is expected to be a safe existence check, but this parse call raises on malformed dotted inputs (for example foo..bar or foo.), which now propagates exceptions to callers like controller dry-run dependency checks instead of returning None. That turns ordinary user typos into runtime errors rather than a normal “pipe not found” path.
Useful? React with 👍 / 👎.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| # If it's a domain-qualified ref (e.g. "scoring.compute_score"), try the local code | ||
| if "." in pipe_code: | ||
| ref = QualifiedRef.parse(pipe_code) | ||
| return self.root.get(ref.local_code) |
There was a problem hiding this comment.
get_optional_pipe raises on malformed pipe codes
Medium Severity
The QualifiedRef.parse() call in get_optional_pipe is not wrapped in a try-except, so it raises QualifiedRefError for malformed inputs like "a..b", ".foo", or "foo.". The old implementation always returned None for unrecognized pipe codes. This breaks the method's Optional return contract and affects callers like the CLI which command, where user-provided pipe codes are passed directly without validation, turning a graceful "not found" into an unhandled crash.
1 participant
Summary
QualifiedRefmodel for hierarchical domain-qualified references (e.g.,domain.subdomain::PipeName)Test plan
QualifiedRefparsing and formatting with valid/invalid inputsmake agent-test🤖 Generated with Claude Code
Note
Medium Risk
Touches core parsing/validation for domains, concept refs, and pipe lookup; could reject previously-accepted edge-case strings or change reference resolution behavior across bundles.
Overview
Enables hierarchical domain codes (e.g.
legal.contracts) and domain-qualified references for concepts/pipes throughout bundle parsing and validation.Introduces
QualifiedRefas a central parser/validator for dotted refs, updates concept/domain/multiplicity validation to accept multi-segment domains, and tightens bundle validation by checking same-domain qualified pipe references in controller blueprints while continuing to ignore external refs and special outcomes.Updates builder
.mthdspipelines to use fully-qualified pipe codes (e.g.builder.*,pipe_design.detail_pipe_spec), and adds extensive unit + integration fixtures/tests covering valid/invalid hierarchical domains and cross-domain concept/pipe references.Written by Cursor Bugbot for commit afe1585. This will update automatically on new commits. Configure here.