Open
Conversation
Pithikos
reviewed
Dec 18, 2023
| volatile int num_threads_working; /* threads currently working */ | ||
| pthread_mutex_t thcount_lock; /* used for thread count etc */ | ||
| pthread_cond_t threads_all_idle; /* signal to thpool_wait */ | ||
| jobqueue jobqueue; /* job queue */ |
Owner
There was a problem hiding this comment.
I guess this is the main issue with C++? Do you think we could simply use jobqueue_t instead?
Namely I'm a bit hesitant, since renaming to job_queue breaks naming convention with other functions
Author
There was a problem hiding this comment.
I think of a simple way to solve it by using extern "C" to avoid problems in C++.
Author
There was a problem hiding this comment.
But there is also a problem with this code style. The struct name should not be consistent with the variable name.
Author
There was a problem hiding this comment.
Using jobqueue_t may be a better choice.
There was a problem hiding this comment.
jobqueue_t is not good. _t is reserved for POSIX structures. Normal developer should not define a type end with _t.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #95 #52