Skip to content

Procedural Drum Synthesis Enhancements (DSP Analysis)#57

Open
Pitrat-wav wants to merge 1 commit intomainfrom
feat/drum-dsp-synthesis-3205841593049366977
Open

Procedural Drum Synthesis Enhancements (DSP Analysis)#57
Pitrat-wav wants to merge 1 commit intomainfrom
feat/drum-dsp-synthesis-3205841593049366977

Conversation

@Pitrat-wav
Copy link
Copy Markdown
Owner

This PR implements deep DSP-level enhancements to the procedural drum synthesis engine, following the provided research on Roland TR-808 and TR-909 emulations.

Key changes include:

  1. Velocity Sensitivity: All drum models now accept a velocity parameter that scales their amplitude envelopes (VCA).
  2. Analog Variance: The sequencer now triggers drums with randomized velocity (0.7 - 1.0) to simulate the "breathing" character of analog hardware.
  3. Master Saturation: A new master DRIVE control on the drum bus implements a non-linear soft-clipping curve (tanh approximation) via a WaveShaperNode, as detailed in the research.
  4. Improved Default Patterns: Default Euclidean settings have been updated to provide a more cohesive "drum party" experience out of the box.
  5. Independent Hi-Hat Routing: Fixed a routing issue to allow separate volume control for Open and Closed Hi-Hats.
  6. UI Enhancements: Added a 'DRIVE' knob to the Drums view.

Verified via TypeScript check (tsc --noEmit) and visual inspection of the UI via Playwright screenshots.


PR created automatically by Jules for task 3205841593049366977 started by @Pitrat-wav

…esearch

- Added velocity scaling to TR-808 and TR-909 drum models (Kick, Snare, Hi-Hat, Clap).
- Implemented master drum saturation (DRIVE) using a soft-clipping WaveShaper.
- Added per-hit velocity randomization (0.7 - 1.0) in the sequencer to simulate analog variance.
- Fixed independent volume routing for Open Hi-Hats.
- Updated default Euclidean patterns for an immediate 'drum party' experience.
- Added DRIVE control to the DrumsView UI.

Co-authored-by: Pitrat-wav <255843145+Pitrat-wav@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant