Skip to content

Drum Party DSP Enhancement#58

Open
Pitrat-wav wants to merge 1 commit intomainfrom
drum-party-dsp-enhancement-3709372416892172935
Open

Drum Party DSP Enhancement#58
Pitrat-wav wants to merge 1 commit intomainfrom
drum-party-dsp-enhancement-3709372416892172935

Conversation

@Pitrat-wav
Copy link
Copy Markdown
Owner

This update brings the drum machine in line with advanced DSP research for analog-style synthesis. Key improvements include:

  • Velocity Sensitivity: All drum models now respond to velocity, scaling both tonal and noise components.
  • Analog Drift: Per-hit micro-randomization of oscillator pitch (+/- 1Hz), filter cutoffs (+/- 2%), and envelope decay times (+/- 2%) to eliminate "machine-gun" effects.
  • Master Saturation: Added a global 'DRIVE' control that applies non-linear soft-clipping to the drum bus, providing harmonic warmth and "glue".
  • Refined Routing: Separated the Open Hi-Hat signal path for precise mix control.
  • Improved Defaults: Reconfigured Euclidean patterns to provide a compelling rhythmic foundation out of the box.

PR created automatically by Jules for task 3709372416892172935 started by @Pitrat-wav

- Enhanced TR-808 and TR-909 synthesis models with velocity scaling and micro-randomization (pitch drift, filter variance, decay variance).
- Implemented master drum saturation (DRIVE) using WaveShaper with soft-clipping tanh curve.
- Fixed audio routing for independent Open Hi-Hat volume control.
- Updated default Euclidean patterns for an immediate "drum party" experience.
- Added DRIVE control to the Drums UI.
- Implemented velocity randomization in the sequencer for organic feel.

Co-authored-by: Pitrat-wav <255843145+Pitrat-wav@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant