Procedural Drum Synthesis & Master Saturation Implementation#60
Procedural Drum Synthesis & Master Saturation Implementation#60Pitrat-wav wants to merge 1 commit intomainfrom
Conversation
- Update TR-808 and TR-909 drum models with velocity scaling and research-aligned micro-randomization. - Add 1000Hz smoothing Low-Pass Filter to TR-909 Kick body. - Implement master saturation (Drive) in DrumMachine using a soft-clipping WaveShaper. - Fix hi-hat volume routing and add global saturation control to audio store. - Implement 0.7-1.0 velocity randomization in the sequencer for analog feel. - Add 'DRIVE' control to the Drums UI. Co-authored-by: Pitrat-wav <255843145+Pitrat-wav@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR implements procedural drum synthesis refinements according to the provided DSP research paper.
Key changes:
TR808Kick,TR909Kick,TR808Snare,TR909Snare,TR808HiHat,TR808Clap) now accept a velocity parameter that scales their amplitude envelopes.WaveShaperNodein theDrumMachineusing a soft-clipping formula. Added a 'DRIVE' knob to theDrumsViewto control this effect.SequencerLoopnow triggers drums with randomized velocity (0.7 - 1.0) to simulate analog variance and prevent the 'machine gun' effect.audioStore.tswhere Open Hi-Hat volume was incorrectly mapped. Addedsaturationstate to manage the new master drive effect.All changes have been verified via TypeScript type checks and visual inspection of the frontend.
PR created automatically by Jules for task 2128357223377739677 started by @Pitrat-wav