Open
Conversation
…e/port-ruby-driver Pulled from master
stakach
requested changes
Apr 6, 2022
Member
stakach
left a comment
stakach
left a comment
There was a problem hiding this comment.
Actually, I think we should implement the other common camera interfaces
https://github.com/PlaceOS/drivers/blob/master/drivers/sony/camera/cgi_protocol.cr#L8
This implements a bunch of other interfaces
https://github.com/PlaceOS/driver/blob/master/src/placeos-driver/interface/camera.cr#L6
If there is a function that you can't implement due to limitations of what this camera can do, then just have it raise an error
pkheav
reviewed
Apr 7, 2022
drivers/qsc/q_sys_camera.cr
Outdated
Comment on lines
1
to
2
| # encoding: ASCII-8BIT | ||
| # frozen_string_literal: true |
Contributor
Member
There was a problem hiding this comment.
Yeah not needed, all strings are UTF8 in crystal
That was a ruby hack to get around windows encoding leaking in if people edited files on windows
caspiano
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Ported existing ruby driver code to crystal.
Note - TODO
I didn't add the spec test for this driver. It depends on a driver with generic_name:Mixer - like the q_sys_control.cr - and I'm not sure of the expected return values.