Skip to content

New checks#48

Merged
wgrzeszczak merged 23 commits intomasterfrom
new-checks
Mar 19, 2026
Merged

New checks#48
wgrzeszczak merged 23 commits intomasterfrom
new-checks

Conversation

@wgrzeszczak
Copy link
Contributor

@wgrzeszczak wgrzeszczak commented Mar 17, 2026

Linting Checks (platformos-check-common):

  1. TranslationKeyExists enhancement — When a translation key doesn't exist, suggests the nearest valid key using Levenshtein distance (e.g., general.titel → "Did you mean general.title?"). Also introduces shared levenshtein and flattenTranslationKeys utilities.

  2. NestedGraphQLQuery (new check) — Detects {% graphql %} tags inside {% for %} or {% tablerow %} loops (N+1 query pattern). Downgrades to INFO severity if wrapped in {% cache %}, and ignores {% background %} blocks.

  3. MissingRenderPartialArguments (new check) — When rendering a partial that has {% doc %} with @param declarations, reports an error if required parameters are missing from the {% render %} call. Includes fix suggestions.

LSP Features (platformos-language-server-common):

  1. GraphQL field hover & completions — Adds hover info and autocompletion for .graphql files using the graphql-language-service library, powered by the project's GraphQL schema.

@wgrzeszczak wgrzeszczak requested a review from Slashek March 17, 2026 08:31
email:
type: string
---
{{ params.token }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm. It doesn't work like that, does it? You can access page metadata through context.page.metadata.*

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this test, I don't even know if this is a partial or a page; partial metadata can't be accessed through liquid, I guess, they can only be fetched through GraphQL.

@wgrzeszczak wgrzeszczak merged commit 2254a41 into master Mar 19, 2026
15 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants