new syntax for modules

.github/workflows/lint.yml

@@ -1,4 +1,5 @@
 name: Lint modules
+run-name: ${{ inputs.module && format('Lint {0}', inputs.module) || ' ' }}
 
 on:
   pull_request:
@@ -9,6 +10,26 @@ on:
     paths-ignore:
       - "**/README.md"
   workflow_dispatch:
+    inputs:
+      module:
+        description: 'Module to lint (e.g., common-styling, user, chat)'
+        required: true
+        type: choice
+        options:
+          - chat
+          - common-styling
+          - core
+          - data-export-api
+          - oauth-facebook
+          - oauth-github
+          - oauth-google
+          - openai
+          - payments
+          - payments-example-gateway
+          - payments-stripe
+          - reports
+          - tests
+          - user
 
 jobs:
   pre_job:
@@ -25,7 +46,7 @@ jobs:
 
   detect-changes:
     needs: pre_job
-    if: ${{ needs.pre_job.outputs.should_skip != 'true' }}
+    if: ${{ github.event_name != 'workflow_dispatch' && needs.pre_job.outputs.should_skip != 'true' }}
     runs-on: ubuntu-latest
     outputs:
       changed-modules: ${{ steps.set-matrix.outputs.matrix }}
@@ -74,63 +95,66 @@ jobs:
           echo "matrix=$modules" >> $GITHUB_OUTPUT
           echo "Changed modules for linting: $modules"
 
-  lint-platformos-check:
-    needs: detect-changes
-    if: needs.detect-changes.outputs.changed-modules != '[]'
+  run-linter:
+    needs: [pre_job, detect-changes]
+    if: |
+      always() &&
+      needs.pre_job.outputs.should_skip != 'true' &&
+      (github.event_name == 'workflow_dispatch' ||
+       needs.detect-changes.outputs.changed-modules != '[]')
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        module: ${{ fromJSON(needs.detect-changes.outputs.changed-modules) }}
+        module: ${{ github.event_name == 'workflow_dispatch' && fromJSON(format('["{0}"]', inputs.module)) || fromJSON(needs.detect-changes.outputs.changed-modules) }}
       fail-fast: false
     env:
       CI: true
-      PLATFORMOS_CHECK_DEBUG: true
-      DOCKER_WORKSPACE: ${{ github.workspace }}/pos-module-${{ matrix.module }}
       LOGS_DIR: ${{ github.workspace }}/pos-module-${{ matrix.module }}/logs
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
 
+      - name: Set up Node.js
+        uses: actions/setup-node@v3
+        with:
+          node-version: '22'
+
+      - name: Install pos-cli
+        id: install_pos_cli
+        run: npm install -g @platformos/pos-cli@latest
+
       - name: Set up logs directory
+        if: steps.install_pos_cli.outcome == 'success'
         run: |
           mkdir -p ${{ env.LOGS_DIR }}
           chmod -R 777 ${{ env.LOGS_DIR }}
 
-      - name: Start PlatformOS LSP
-        id: start_lsp
+      - name: Install modules
+        if: steps.install_pos_cli.outcome == 'success'
         run: |
-          docker run -i \
-            -v ${{ env.DOCKER_WORKSPACE }}:${{ env.DOCKER_WORKSPACE }} \
-            -w ${{ env.DOCKER_WORKSPACE }} \
-            -e PLATFORMOS_CHECK_DEBUG=${{ env.PLATFORMOS_CHECK_DEBUG }} \
-            -e PLATFORMOS_CHECK_DEBUG_LOG_FILE=${{ env.LOGS_DIR }}/platformos-lsp.log \
-            platformos/platformos-lsp:latest
-
-      - name: Run platformos-check
-        if: steps.start_lsp.outcome == 'success'
+          cd pos-module-${{ matrix.module }}
+          mkdir -p app
+          pos-cli modules install
+
+      - name: Run pos-cli check
+        if: steps.install_pos_cli.outcome == 'success'
         id: run_check
         run: |
           set +e  # Disable exit on error
-          docker run -i \
-            -v ${{ env.DOCKER_WORKSPACE }}:${{ env.DOCKER_WORKSPACE }} \
-            -w ${{ env.DOCKER_WORKSPACE }} \
-            -e PLATFORMOS_CHECK_DEBUG=${{ env.PLATFORMOS_CHECK_DEBUG }} \
-            -e PLATFORMOS_CHECK_DEBUG_LOG_FILE=${{ env.LOGS_DIR }}/platformos-check.log \
-            platformos/platformos-check:latest -o json > ${{ env.LOGS_DIR }}/platformos-check-raw.json
-          docker_exit_code=$?
+          pos-cli check run pos-module-${{ matrix.module }} -f json > ${{ env.LOGS_DIR }}/platformos-check-raw.json
+          check_exit_code=$?  # Capture the exit code
           set -e  # Re-enable exit on error
 
           jq . ${{ env.LOGS_DIR }}/platformos-check-raw.json | tee ${{ env.LOGS_DIR }}/platformos-check.json
 
-          exit $docker_exit_code
+          exit $check_exit_code
 
       - name: Upload logs
         if: always() && steps.run_check.outcome != 'skipped'
         uses: actions/upload-artifact@v4
         with:
           name: platformos_check_logs_${{ matrix.module }}_${{ github.run_id }}
           path: |
-            ${{ env.LOGS_DIR }}/platformos-lsp.log
             ${{ env.LOGS_DIR }}/platformos-check.json
             ${{ env.LOGS_DIR }}/platformos-check-raw.json
 
@@ -142,19 +166,86 @@ jobs:
           echo "" >> $GITHUB_STEP_SUMMARY
 
           if [ -f "${{ env.LOGS_DIR }}/platformos-check.json" ]; then
-            echo "## Issues Found" >> $GITHUB_STEP_SUMMARY
-            echo "| File | Line | Column | Severity | Check | Message |" >> $GITHUB_STEP_SUMMARY
-            echo "|------|------|--------|----------|-------|---------|" >> $GITHUB_STEP_SUMMARY
-
-            # Try to parse and add issues
-            if jq -r '.[] | .path as $file | .offenses[] | "| \($file) | \(.start_row) | \(.start_column) | \(.severity) | \(.check) | \(.message) |"' ${{ env.LOGS_DIR }}/platformos-check.json >> $GITHUB_STEP_SUMMARY 2>&1; then
-              echo "Issues table generated successfully"
-            else
-              echo "| N/A | N/A | N/A | N/A | N/A | Failed to parse JSON - see logs for details |" >> $GITHUB_STEP_SUMMARY
-              echo "JSON parse error. File contents:" >> $GITHUB_STEP_SUMMARY
-              echo '```json' >> $GITHUB_STEP_SUMMARY
-              cat ${{ env.LOGS_DIR }}/platformos-check.json >> $GITHUB_STEP_SUMMARY
-              echo '```' >> $GITHUB_STEP_SUMMARY
+            JSON="${{ env.LOGS_DIR }}/platformos-check.json"
+
+            # Summary statistics
+            echo "## Summary" >> $GITHUB_STEP_SUMMARY
+            echo "| Metric | Count |" >> $GITHUB_STEP_SUMMARY
+            echo "|--------|-------|" >> $GITHUB_STEP_SUMMARY
+            jq -r '"| Total Offenses | \(.offenseCount) |", "| Files with Issues | \(.fileCount) |", "| Errors | \(.errorCount) |", "| Warnings | \(.warningCount) |", "| Info | \(.infoCount) |"' "$JSON" >> $GITHUB_STEP_SUMMARY
+            echo "" >> $GITHUB_STEP_SUMMARY
+
+            # Offenses by check type
+            echo "## Offenses by Check Type" >> $GITHUB_STEP_SUMMARY
+            echo "| Check | Total | Errors | Warnings |" >> $GITHUB_STEP_SUMMARY
+            echo "|-------|-------|--------|----------|" >> $GITHUB_STEP_SUMMARY
+            jq -r '
+              [.files[].offenses[]] | group_by(.check)
+              | map({
+                  check: .[0].check,
+                  total: length,
+                  errors: map(select(.severity == "error")) | length,
+                  warnings: map(select(.severity == "warning")) | length
+                })
+              | sort_by(-.total)
+              | .[]
+              | "| `\(.check)` | \(.total) | \(.errors) | \(.warnings) |"
+            ' "$JSON" >> $GITHUB_STEP_SUMMARY
+            echo "" >> $GITHUB_STEP_SUMMARY
+
+            # Errors section — full detail for files with errors
+            ERROR_FILE_COUNT=$(jq '[.files[] | select(.errorCount > 0)] | length' "$JSON")
+            if [ "$ERROR_FILE_COUNT" -gt 0 ]; then
+              echo "## Errors ($ERROR_FILE_COUNT files)" >> $GITHUB_STEP_SUMMARY
+              echo "" >> $GITHUB_STEP_SUMMARY
+              jq -r '
+                [.files[] | select(.errorCount > 0)]
+                | sort_by(-.errorCount)
+                | .[]
+                | "### \u274c `\(.path)`",
+                  "",
+                  "**Errors:** \(.errorCount) | **Warnings:** \(.warningCount)",
+                  "",
+                  "| Line | Col | Severity | Check | Message |",
+                  "|------|-----|----------|-------|---------|",
+                  (.offenses | sort_by(
+                    (if .severity == "error" then 0 elif .severity == "warning" then 1 else 2 end),
+                    .start_row
+                  ) | .[] | "| \(.start_row) | \(.start_column) | \(.severity) | `\(.check)` | \(.message | gsub("\n"; " ")) |"),
+                  ""
+              ' "$JSON" >> $GITHUB_STEP_SUMMARY
+            fi
+
+            # Warnings section — collapsed, only top files shown
+            WARNING_ONLY_COUNT=$(jq '[.files[] | select(.errorCount == 0 and .warningCount > 0)] | length' "$JSON")
+            if [ "$WARNING_ONLY_COUNT" -gt 0 ]; then
+              TOTAL_WARNINGS=$(jq '.warningCount' "$JSON")
+              echo "<details>" >> $GITHUB_STEP_SUMMARY
+              echo "<summary>## Warnings — ${TOTAL_WARNINGS} across ${WARNING_ONLY_COUNT} files (click to expand)</summary>" >> $GITHUB_STEP_SUMMARY
+              echo "" >> $GITHUB_STEP_SUMMARY
+
+              # Show top 20 files by warning count
+              jq -r '
+                [.files[] | select(.errorCount == 0 and .warningCount > 0)]
+                | sort_by(-.warningCount)
+                | .[:20]
+                | .[]
+                | "### \u26a0\ufe0f `\(.path)` — \(.warningCount) warnings",
+                  "",
+                  "| Line | Col | Check | Message |",
+                  "|------|-----|-------|---------|",
+                  (.offenses | sort_by(.start_row)
+                  | .[] | "| \(.start_row) | \(.start_column) | `\(.check)` | \(.message | gsub("\n"; " ")) |"),
+                  ""
+              ' "$JSON" >> $GITHUB_STEP_SUMMARY
+
+              REMAINING=$((WARNING_ONLY_COUNT - 20))
+              if [ "$REMAINING" -gt 0 ]; then
+                echo "...and ${REMAINING} more files with warnings only." >> $GITHUB_STEP_SUMMARY
+                echo "" >> $GITHUB_STEP_SUMMARY
+              fi
+
+              echo "</details>" >> $GITHUB_STEP_SUMMARY
             fi
           else
             echo "## No output file found" >> $GITHUB_STEP_SUMMARY

pos-module-chat/modules/chat/public/lib/consumers/chat_message_created/notify_of_new_message.liquid

@@ -7,7 +7,7 @@
     assign last_message = g.messages.results.first
 
     if last_message.id == message.id
-      assign event_object = null | hash_merge: message_id: message.id, app_host: app_host
+      assign event_object = {"message_id": message.id, "app_host": app_host}
 
       function _ = 'modules/core/commands/events/publish', type: 'message_notification_to_send', object: event_object
     endif

pos-module-chat/modules/chat/public/lib/events/chat_message_created.liquid

@@ -5,7 +5,7 @@ metadata:
     app_host
 ---
 {% liquid
-  assign c = '{ "errors": {}, "valid": true }' | parse_json
+  assign c = { "errors": {}, "valid": true }
 
   function c = 'modules/core/validations/presence', c: c, object: event, field_name: 'message_id'
   function c = 'modules/core/validations/presence', c: c, object: event, field_name: 'app_host'

pos-module-chat/modules/chat/public/lib/events/message_notification_to_send.liquid

@@ -5,7 +5,7 @@ metadata:
     app_host
 ---
 {% liquid
-  assign c = '{ "errors": {}, "valid": true }' | parse_json
+  assign c = { "errors": {}, "valid": true }
 
   function c = 'modules/core/validations/presence', c: c, object: event, field_name: 'message_id'
   function c = 'modules/core/validations/presence', c: c, object: event, field_name: 'app_host'

pos-module-chat/modules/chat/public/views/pages/inbox.html.liquid

@@ -11,7 +11,7 @@ slug: inbox
   if context.params.to_uuid != blank
     function record = 'modules/chat/lib/queries/records/find_by_uuid', uuid: context.params['to_uuid']
   endif
-  assign object = null | hash_merge: to_id: record.id, conversation_id: context.params['conversation_id']
+  assign object = {"to_id": record.id, "conversation_id": context.params['conversation_id']}
   if record or context.params.conversation_id
     function current_conversation = 'modules/chat/lib/commands/conversations/find_or_create', object: object, current_profile: current_profile
   endif
@@ -33,7 +33,7 @@ slug: inbox
   if conversations.total_entries > 0
     if current_conversation and current_conversation.participants == blank
       graphql participants = 'modules/user/profiles/search', ids: current_conversation.participant_ids
-      hash_assign current_conversation['participants'] = participants.records.results
+      assign current_conversation.participants = participants.records.results
     endif
 
     render 'modules/chat/inbox', current_conversation: current_conversation, conversations: conversations, current_profile: current_profile

pos-module-chat/modules/chat/public/views/partials/channels/conversate/receive.liquid

@@ -21,10 +21,7 @@
   function conversation = 'modules/chat/lib/queries/conversations/find_by_participant', id: room_id, participant_id: current_profile.id, include_messages: null
   if conversation
     assign message_safe = context.params.message | raw_escape_string
-    assign object = '{}' | parse_json
-    hash_assign object['conversation_id'] = conversation.id
-    hash_assign object['autor_id'] = current_profile.id
-    hash_assign object['message'] = message_safe
+    assign object = { "conversation_id": conversation.id, "autor_id": current_profile.id, "message": message_safe }
     function message = 'modules/chat/lib/commands/messages/create', object: object
     if message.valid != true
       log message, 'ERROR receive message'

pos-module-chat/modules/chat/public/views/partials/inbox.liquid

@@ -41,7 +41,7 @@
 <script type="module" defer src="{{ 'modules/chat/js/pos-chat.js' | asset_url }}"></script>
 
 <!-- message templates -->
-{% assign dummy_message = '{ "message": "", "created_at": null }' | parse_json %}
+{% assign dummy_message = { "message": "", "created_at": null } %}
 <template id="pos-chat-template-message-received">
   {% render 'modules/chat/message', message: dummy_message, authored: false, timezone: null %}
 </template>

pos-module-chat/modules/chat/public/views/partials/lib/commands/conversations/create/build.liquid

@@ -1,7 +1,5 @@
 {% liquid
-  assign data = '{}' | parse_json
-  hash_assign data['participant_ids'] = object.participant_ids
-  hash_assign data['participant_read_ids'] = current_profile.id
+  assign data = { "participant_ids": object.participant_ids, "participant_read_ids": current_profile.id }
 
   return data
-%}
+ %}

pos-module-chat/modules/chat/public/views/partials/lib/commands/conversations/create/check.liquid

@@ -1,12 +1,12 @@
 {% liquid
-  assign c = '{ "errors": {}, "valid": true }' | parse_json
+  assign c = { "errors": {}, "valid": true }
 
   function c = 'modules/core/validations/presence', c: c, object: object, field_name: 'participant_ids'
   function c = 'modules/core/validations/length', c: c, object: object, field_name: 'participant_ids', minimum: 2, allow_blank: null
   function c = 'modules/core/validations/presence', c: c, object: object, field_name: 'participant_read_ids'
 
-  hash_assign object['valid'] = c.valid
-  hash_assign object['errors'] = c.errors
+  assign object.valid = c.valid
+  assign object.errors = c.errors
 
   return object
-%}
+ %}

pos-module-chat/modules/chat/public/views/partials/lib/commands/conversations/find_or_create.liquid

@@ -7,7 +7,7 @@
     function conversation = 'modules/chat/lib/queries/conversations/find_by_participants', participant_ids: object.participant_ids, include_messages: true
     unless conversation
       function conversation = 'modules/chat/lib/commands/conversations/create', object: object, current_profile: current_profile
-      hash_assign conversation['created'] = true
+      assign conversation.created = true
     endunless
   endif
 

pos-module-chat/modules/chat/public/views/partials/lib/commands/conversations/find_or_create/build.liquid

@@ -1,8 +1,6 @@
 {% liquid
-  assign participants = '[]' | parse_json | add_to_array: current_profile.id | add_to_array: object['to_id'] | uniq | compact | sort
-  assign data = '{}' | parse_json
-  hash_assign data['participant_ids'] = participants
-  hash_assign data['conversation_id'] = object.conversation_id
+  assign participants = [current_profile.id, object.to_id] | uniq | compact | sort
+  assign data = { "participant_ids": participants, "conversation_id": object.conversation_id }
 
   return data
-%}
+ %}

pos-module-chat/modules/chat/public/views/partials/lib/commands/conversations/find_or_create/check.liquid

@@ -4,9 +4,9 @@
 
     assign types = object.participants | map: 'type' | uniq
     if types.size == 1 and types.first == 'profile'
-      hash_assign object['valid'] = false
+      assign object.valid = false
     endif
   endcomment
 
   return object
-%}
+ %}

pos-module-chat/modules/chat/public/views/partials/lib/commands/conversations/mark_read/build.liquid

@@ -1,8 +1,5 @@
 {% liquid
-  assign data = '{}' | parse_json
-  hash_assign data['id'] = conversation.id
-  hash_assign data['participant_read_ids'] = conversation.participant_read_ids
-  hash_assign data['participant_id'] = participant_id
+  assign data = { "id": conversation.id, "participant_read_ids": conversation.participant_read_ids, "participant_id": participant_id }
 
   return data
-%}
+ %}

pos-module-chat/modules/chat/public/views/partials/lib/commands/conversations/mark_read/check.liquid

@@ -1,11 +1,11 @@
 {% liquid
-  assign c = '{ "errors": {}, "valid": true }' | parse_json
+  assign c = { "errors": {}, "valid": true }
 
   function c = 'modules/core/validations/presence', c: c, object: object, field_name: 'id'
   function c = 'modules/core/validations/presence', c: c, object: object, field_name: 'participant_id'
 
-  hash_assign object['valid'] = c.valid
-  hash_assign object['errors'] = c.errors
+  assign object.valid = c.valid
+  assign object.errors = c.errors
 
   return object
-%}
+ %}

pos-module-chat/modules/chat/public/views/partials/lib/commands/conversations/mark_unread/build.liquid

@@ -1,7 +1,5 @@
 {% liquid
-  assign data = '{}' | parse_json
-  hash_assign data['id'] = conversation.id
-  hash_assign data['participant_read_ids'] = current_profile.id
+  assign data = { "id": conversation.id, "participant_read_ids": current_profile.id }
 
   return data
-%}
+ %}