Conversation
Contributor
|
@AlonsoMondal Can you run this through the XplatCpp build pipeline and make sure things look okay? |
Contributor
|
Hey, sorry about the late response, we had an issue with running generation using a custom branch for the template repo. PS: PR above should be abandoned once we're done here. |
amccalib
approved these changes
Apr 27, 2023
AlonsoMondal
approved these changes
Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Sanity check that iOS also is generated properly and that test app builds - need a valid json to run it - if I can get one I can test it (relates to XPlatCppSdk)