fix: prevent capturing stale NotebookLM responses#28
Open
bluzername wants to merge 1 commit intoPleasePrompto:masterfrom
Open
fix: prevent capturing stale NotebookLM responses#28bluzername wants to merge 1 commit intoPleasePrompto:masterfrom
bluzername wants to merge 1 commit intoPleasePrompto:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using
ask_question.pyon a notebook that already has chat history, the script can return a stale/older response instead of the newly generated answer.I was hitting this myself - the script kept returning the generic notebook intro text instead of the actual answer that was visible in the browser UI. Very confusing.
Root Cause
The polling logic at line 141 does
elements[-1]to get the "newest" response, but this is wrong because:What I changed
Rewrote the response polling section in
scripts/ask_question.py:Before submit:
During polling:
Timeout:
How it works now
The old approach was just taking
elements[-1]which could be any previously existing response.Closes #25