resolve #5 admin can activate/deactivate users#14
Closed
YehiaFarghaly wants to merge 1 commit intodevfrom
Closed
Conversation
NourAlPha
requested changes
May 2, 2025
Contributor
There was a problem hiding this comment.
Please remove the log files. I have added this to .gitignore in one of my running PRs.
| public class AdminController { | ||
|
|
||
| private final AdminService adminService; | ||
| private static final Logger logger = LoggerFactory.getLogger(AdminController.class); |
Contributor
There was a problem hiding this comment.
Static final instances should be all caps. This should be handled by the linter.
| @PathVariable Long userId, | ||
|
|
||
| @Parameter(description = "Set to true to activate, false to deactivate the user") | ||
| @RequestParam boolean isActive) { |
Contributor
There was a problem hiding this comment.
Can you please rename this variable and all its subsequent variables to enabled to match the UserDetails convention?
| @Service | ||
| public class AdminService { | ||
|
|
||
| private static final Logger logger = LoggerFactory.getLogger(AdminService.class); |
Contributor
There was a problem hiding this comment.
Same thing here for the logger.
Contributor
|
Also, please fix the linter errors -- try to install it locally ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.