Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the admin service by adding user details caching and refactors user detail creation for consistency and maintainability.
- Implements cache eviction and update methods in AdminService.
- Refactors user details creation to use a centralized static method.
- Updates authentication endpoints in SecurityConfig and refactors CustomUserDetails with Lombok.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| CustomUserDetailsService.java | Refactored to use a centralized getUserDetails method. |
| AdminService.java | Added cache eviction/put methods and centralized user details creation. |
| SecurityConfig.java | Updated request matchers to enforce POST for authentication endpoints. |
| User.java | Changed the ID generation strategy and added default builder values for fields. |
| CustomUserDetails.java | Refactored using Lombok annotations and the builder pattern for clarity. |
…e CacheService for user details management
YehiaFarghaly
approved these changes
May 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.