test: add unit and integration tests for courier analytics

docker-compose.yml

@@ -7,8 +7,8 @@ services:
       - "8080:8080"
     environment:
       SPRING_DATASOURCE_URL: jdbc:postgresql://db:5432/analytics_db_dev
-      SPRING_DATASOURCE_USERNAME: analytics_user
-      SPRING_DATASOURCE_PASSWORD: password
+      SPRING_DATASOURCE_USERNAME: postgres
+      SPRING_DATASOURCE_PASSWORD: 123
       SPRING_RABBITMQ_HOST: rabbitmq # RabbitMQ container name or use its IP if needed
       SPRING_RABBITMQ_PORT: 5672
       SPRING_RABBITMQ_USERNAME: guest
@@ -23,8 +23,8 @@ services:
       - "5432:5432"
     environment:
       POSTGRES_DB: analytics_db_dev
-      POSTGRES_USER: analytics_user
-      POSTGRES_PASSWORD: password
+      POSTGRES_USER: postgres
+      POSTGRES_PASSWORD: 123
     volumes:
       - db_data:/var/lib/postgresql/data
 
@@ -47,4 +47,3 @@ services:
 
 volumes:
   db_data:
-

src/main/java/com/Podzilla/analytics/repositories/CourierRepository.java

@@ -23,7 +23,6 @@ public interface CourierRepository extends JpaRepository<Courier, Long> {
             + "LEFT JOIN orders o "
             + "ON c.id = o.courier_id "
             + "AND o.final_status_timestamp BETWEEN :startDate AND :endDate "
-            + "AND o.status IN ('COMPLETED', 'FAILED') "
             + "GROUP BY c.id, c.name "
             + "ORDER BY courierId", nativeQuery = true)
     List<CourierPerformanceProjection> findCourierPerformanceBetweenDates(

src/main/java/com/Podzilla/analytics/services/CourierAnalyticsService.java

@@ -53,7 +53,7 @@ public List<CourierSuccessRateResponse> getCourierSuccessRate(
                         .courierId(data.getCourierId())
                         .courierName(data.getCourierName())
                         .successRate(
-                                MetricCalculator.calculatePercentage(
+                                MetricCalculator.calculateRate(
                                         data.getCompletedCount(),
                                         data.getDeliveryCount()))
                         .build())
@@ -81,7 +81,7 @@ public List<CourierPerformanceReportResponse> getCourierPerformanceReport(
                         .courierName(data.getCourierName())
                         .deliveryCount(data.getDeliveryCount())
                         .successRate(
-                                MetricCalculator.calculatePercentage(
+                                MetricCalculator.calculateRate(
                                         data.getCompletedCount(),
                                         data.getDeliveryCount()))
                         .averageRating(data.getAverageRating())

src/main/java/com/Podzilla/analytics/util/MetricCalculator.java

@@ -6,8 +6,6 @@
 public final class MetricCalculator {
     private static final int DEFAULT_SCALE = 2;
 
-    private static final BigDecimal ONE_HUNDRED = new BigDecimal("100");
-
     private MetricCalculator() {
         throw new UnsupportedOperationException(
                 "This is a utility class and cannot be instantiated");
@@ -25,7 +23,7 @@ private MetricCalculator() {
      * @return The calculated percentage as a BigDecimal, or BigDecimal.ZERO
      *         if the denominator is zero.
      */
-    public static BigDecimal calculatePercentage(final long numerator,
+    public static BigDecimal calculateRate(final long numerator,
             final long denominator, final int scale,
             final RoundingMode roundingMode) {
         if (denominator == 0) {
@@ -35,7 +33,6 @@ public static BigDecimal calculatePercentage(final long numerator,
             return BigDecimal.ZERO;
         }
         return BigDecimal.valueOf(numerator)
-                .multiply(ONE_HUNDRED)
                 .divide(BigDecimal.valueOf(denominator), scale, roundingMode);
     }
 
@@ -47,9 +44,9 @@ public static BigDecimal calculatePercentage(final long numerator,
      * @return The calculated percentage (scale 2, HALF_UP rounding), or
      *         BigDecimal.ZERO if denominator is zero.
      */
-    public static BigDecimal calculatePercentage(final long numerator,
+    public static BigDecimal calculateRate(final long numerator,
             final long denominator) {
-        return calculatePercentage(numerator, denominator, DEFAULT_SCALE,
+        return calculateRate(numerator, denominator, DEFAULT_SCALE,
                 RoundingMode.HALF_UP);
     }
 }