allow for missing kafka/websocket C++ adapters #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkpaine
added
adapter: general
timkpaine
requested review from
robambalu,
AdamGlustein,
svatasoiu and
alexddobkin
as code owners
robambalu
reviewed
May 7, 2024
timkpaine
added
the
tag: wip
timkpaine
force-pushed
the
tkp/defer
branch
3 times, most recently
from
d4ba8e8 to
a25d3e1
Compare
robambalu
previously approved these changes
May 24, 2024
timkpaine
force-pushed
the
tkp/defer
branch
2 times, most recently
from
4d12cfc to
9e0042c
Compare
timkpaine
removed
tag: needs squash
…g parquet adapter after cache cleanup Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com> Raise hard import errors if trying to use adapters with missing dependencies, with helpful error messages. Remove runtime requirement on pandas Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com> Remove superfluous checks Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com> Add oldest supported numpy as runtime dep as well Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com> fix spacing in action, dont depend on oldest-supported-numpy Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com> Isolate sdist build environment Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes incremental progress on adapter separation by enabling the Kafka and Websocket C++ code to not be built. It also removes
pandasas a primary dependency.fixes #251