Open
Conversation
Should also work on touch screens
Owner
|
You may want to check the artifacts, the menus are broken, the button popups as well, and the score is not updating. |
Author
|
No no it is probably on my side because I chopped in little pieces the code, removed some out of scope parts for the training in order to reduce the complexity, then I rebased on your recent changes and that make a tone of conflicts I solved them but I probably forgot to add what I did removed. |
Pokegali
added a commit
that referenced
this pull request
Apr 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set of changes in order to convert code to modern code and also add mouse input/touchscreen management (could be probably improved).
We can discuss about each change if you want to know why.
Also I have some auto indentations so, Many lines are changes but in fact it is just the same code.