Skip to content

Fix PC sound effect playing twice and Trainers eye BGMs#53

Open
Aelysya wants to merge 3 commits intoPokemonWorkshop:mainfrom
Aelysya:fix-audio-issues
Open

Fix PC sound effect playing twice and Trainers eye BGMs#53
Aelysya wants to merge 3 commits intoPokemonWorkshop:mainfrom
Aelysya:fix-audio-issues

Conversation

@Aelysya
Copy link
Copy Markdown
Collaborator

@Aelysya Aelysya commented Feb 21, 2026

This MR fixes three issues related to the recent update of the sound design config.

The PC events were playing the sound effects when openning and closing it, since these sound effects were directly added to the start_pc method, they were played twice.

The trainers meeting sequence BGM were also set in the events with the audio/bgm prefix, leading to the code trying to look for files like Audio/BGM/audio/bgm/file.ogg

Some of the battle arena's battles were calling to audio files with the audio/bgm prefix, leading to the same issue as above.

Tests to perform

  • Try using every different PC events in the demo, their openning and closing sound effects should only play once
  • Try being spotted by all the trainers in the demo, their eye_bgm should be played correctly
  • In the battle arena, all the battles should correctly play their BGM (Especially the fights number 2, 7 and the one against Palbolsky)

@Aelysya Aelysya self-assigned this Feb 21, 2026
@AerunDev AerunDev added bug Something isn't working audio Audio files related issue labels Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

audio Audio files related issue bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants