Fix PC sound effect playing twice and Trainers eye BGMs#53
Open
Aelysya wants to merge 3 commits intoPokemonWorkshop:mainfrom
Open
Fix PC sound effect playing twice and Trainers eye BGMs#53Aelysya wants to merge 3 commits intoPokemonWorkshop:mainfrom
Aelysya wants to merge 3 commits intoPokemonWorkshop:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR fixes three issues related to the recent update of the sound design config.
The PC events were playing the sound effects when openning and closing it, since these sound effects were directly added to the
start_pcmethod, they were played twice.The trainers meeting sequence BGM were also set in the events with the
audio/bgmprefix, leading to the code trying to look for files likeAudio/BGM/audio/bgm/file.oggSome of the battle arena's battles were calling to audio files with the
audio/bgmprefix, leading to the same issue as above.Tests to perform
eye_bgmshould be played correctly