Skip to content

feat(rmxp-map): remove the rmxp map management support#743

Open
Menthx wants to merge 2 commits intodevelopfrom
664-remove-the-rmxp-map-management-support
Open

feat(rmxp-map): remove the rmxp map management support#743
Menthx wants to merge 2 commits intodevelopfrom
664-remove-the-rmxp-map-management-support

Conversation

@Menthx
Copy link
Copy Markdown
Collaborator

@Menthx Menthx commented Apr 10, 2026

Thank you for your contribution to the Pokémon Studio repo.

Before submitting this PR into the develop branch, please make sure:

  • Your code builds clean without any errors or warnings
  • You are following the Code guidelines
  • You tested your code to make sure it does what it is supposed to do

Description

I would like to be guided to the use of Tiled as a single source of truth
So that my project will be ready for the Version 3.0 migration
And the migration will be easier

Note before testing

Pls, make sure to test all the app !

@Menthx Menthx self-assigned this Apr 10, 2026
@Menthx Menthx linked an issue Apr 10, 2026 that may be closed by this pull request
4 tasks
@Palbolsky
Copy link
Copy Markdown
Collaborator

Palbolsky commented Apr 12, 2026

C'est en draft mais j'ai quand même pris le temps de tester ce qui a été fait. Tu as supprimé un service qu'il ne fallait pas supprimer, c'est le src/backendTasks/studioMapToRMXPConversionFacilitator.ts

Ce service est nécessaire pour indiquer à PSDK ce qu'il doit convertir. Sans ce service, les cartes ne sont pas mises à jour dans RMXP ni dans PSDK.

@Menthx Menthx marked this pull request as ready for review April 16, 2026 17:28
@Menthx Menthx force-pushed the 664-remove-the-rmxp-map-management-support branch from 1500bda to f285529 Compare April 16, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the RMXP map management support

2 participants