Skip to content

Conversation

@SakshiKekre
Copy link
Collaborator

@SakshiKekre SakshiKekre commented Nov 11, 2025

Fixes #417

Summary

Complete redesign of household builder with per-person variable customization, entity-aware resolution, and metadata-driven field categorization.

Key Changes

UI/UX (Mockup 3 Design)

  • Accordion-based layout with "Household Members" and "Household Details" sections
  • Per-person variable assignment with inline search
  • Custom variable support for both person-level and household-level entities
  • Read-only tax year display (from report context)

Architecture

  • HouseholdBuilderForm: Pure presentation component (638 lines)
  • HouseholdBuilderFrame: Orchestrator for Redux/API integration
  • VariableResolver: Entity-aware utility for reading/writing variables
  • VariableInput: Reusable input component with metadata-driven formatting

Core Features

  • ✅ Basic inputs: age, employment_income, state_name, etc. (metadata-driven)
  • ✅ Custom variables: Search and add any input variable per person or household
  • ✅ Entity resolution: Variables correctly resolve to person/household/tax_unit/spm_unit/family/marital_unit
  • ✅ Metadata-driven: Field categorization based on metadata.variables[field].entity

Bug Fixes

  • Fixed getBasicInputFields to use metadata entity information instead of hardcoded field names
  • Fixed entity resolution to support all 6 entity types (person, household, tax_unit, spm_unit, family, marital_unit)

@vercel
Copy link

vercel bot commented Nov 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
policyengine-app-v2 Ready Ready Preview Comment Nov 21, 2025 8:11pm

Copy link
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments here, but think this is ready to start!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redo Household Builder Frame

3 participants