generated from mantinedev/vite-template
-
Notifications
You must be signed in to change notification settings - Fork 2
Refactor flows into pathways #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
e371c6c to
76b46a5
Compare
2ee81be to
0b52418
Compare
0b52418 to
922dabd
Compare
SakshiKekre
reviewed
Nov 24, 2025
| * - PARAMETER_SELECTOR: PolicyParameterSelectorFrame (select and configure parameters) | ||
| * - SUBMIT: PolicySubmitFrame (review and submit policy) | ||
| */ | ||
| export enum PolicyViewMode { |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Why do we have PolicyViewMode here as well as in SharedViewMode.ts?
7b6ed50 to
97d4502
Compare
f993d3c to
8da17ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #411
Fixes #412
Fixes #413
Fixes #303
Fixes #304
Refactors the flow architecture into a new concept of "pathways" in order to sustainably enable back and cancel buttons, clean up other visual/state management bugs, and enable the use of predefined baseline simulations.