Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@anth-volk @PavelMakarchuk @MaxGhenis WDYT of this rough proposal.
Structural reforms have always been painful, and they are handled completely different than parametric reforms (and applying changes to the actual data is mostly impossible without modifying the simulation directly, e.g. increasing the earnings growth factor is impossible as a reform currently).
This
Scenarioclass could supersede the existing reform class, make those things all possible, and at the same time add stability, type checking, validation, etc. Happy to write docs etc but want to make sure this has buy-in first.