Skip to content

Skip redundant dataset copy in apply_uprating #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nwoodruff-co merged 1 commit into from
Mar 10, 2026
Merged

Skip redundant dataset copy in apply_uprating #1523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/fix-apply-uprating-redundant-copy.changed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Added `copy` parameter to `apply_uprating` (default `True`); `extend_single_year_dataset` now passes `copy=False` to skip the redundant deep copy of the multi-year dataset since each year is already copied individually.
8 changes: 5 additions & 3 deletions policyengine_uk/data/economic_assumptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,21 +48,23 @@ def extend_single_year_dataset(
return apply_uprating(
multi_year_dataset,
tax_benefit_system_parameters=tax_benefit_system_parameters,
copy=False,
)


def apply_uprating(
dataset: UKMultiYearDataset,
tax_benefit_system_parameters: ParameterNode = None,
copy: bool = True,
):
from policyengine_uk.system import system

# Apply uprating to the dataset.
dataset = dataset.copy()

if not isinstance(dataset, UKMultiYearDataset):
raise TypeError("dataset must be of type UKMultiYearDataset.")

if copy:
dataset = dataset.copy()

for year in dataset.datasets.keys():
if year == min(dataset.datasets.keys()):
continue # Don't uprate the first year
Expand Down