Skip to content

Fix NJ gross income formula that breaks API reform calculations #7743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaxGhenis merged 1 commit into from
Mar 10, 2026
+5 −2
Merged

Fix NJ gross income formula that breaks API reform calculations #7743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/fix-nj-gross-income.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed NJ gross income formula that broke API reform calculations by replacing ParameterNode iteration with explicit category references.
6 changes: 4 additions & 2 deletions policyengine_us/variables/gov/states/nj/tax/income/adjusted_gross_income/nj_gross_income.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ def formula(person, period, parameters):
# Loss-eligible categories per N.J.S. 54A:5-1: each is
# summed within the category then clamped to $0.
cats = p.loss_eligible_categories
for cat in cats:
total += max_(add(person, period, cats[cat]), 0)
total += max_(add(person, period, cats.category_b), 0)
total += max_(add(person, period, cats.category_c), 0)
total += max_(add(person, period, cats.category_d), 0)
total += max_(add(person, period, cats.category_k_p), 0)
return total
Loading