Update dependencies and bump Python version#603
Update dependencies and bump Python version#603Nicholas-Schaub merged 5 commits intoPolusAI:masterfrom
Conversation
|
|
||
|
|
||
| # Install flytekit | ||
| RUN pip3 install "flytekit>=1.16.15" --no-cache-dir |
There was a problem hiding this comment.
check with Nick first on adding "flytekit>=1.16.15".
He is not in favor of adding it in the docker file
There was a problem hiding this comment.
Make sure to run the docker container locally and test it on the real dataset
There was a problem hiding this comment.
I remember Nick mentioning that we shouldn’t make Flytekit a dependency of the tool. But without Flytekit in the Docker image, we won’t be able to call it from our Flyte workflow.
| basicpy = "1.2.0" | ||
| requires-python = ">=3.11,<3.14" | ||
| dependencies = [ | ||
| "bfio>=2.4.7,<3.0.0", |
There was a problem hiding this comment.
don't start with older version of bfio
start with bfio>=2.5.0
There was a problem hiding this comment.
same for file pattern
2.2.4
There was a problem hiding this comment.
we shouldn't be have uv.lock file in the repo
There was a problem hiding this comment.
Updated the tools' version. I think it's better to commit the uv.lock file because it is guaranteeing that all developers and CI get the same versions, and that commands are reproducible.
ndonyapour
force-pushed
the
chore/bump-basicflatfield-pyversion
branch
from
0eacf3b to
b823d6f
Compare
3 participants
This PR updates the dependencies and bumps the Python Version.