bugfix(ci): fix bug in GitHub Actions pre-commit workflow#605
Open
ndonyapour wants to merge 1 commit intoPolusAI:masterfrom
Open
bugfix(ci): fix bug in GitHub Actions pre-commit workflow#605ndonyapour wants to merge 1 commit intoPolusAI:masterfrom
ndonyapour wants to merge 1 commit intoPolusAI:masterfrom
Conversation
Contributor
|
@ndonyapour This looks like it will help fix our problem, but created other problems in the process. The goal of the old version was to only run checks against files changed between two different commits. This would effectively run checks against EVERYTHING. That is great if everything is up to date, but if it's not it will create a big headache. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where pre-commit was run with --from-ref/--to-ref, which can fail when SHA refs are unavailable on fork branches without an open PR.