Skip to content

Fix a bug in the Dockerfile for BaSIC flatfield estimation#608

Open
ndonyapour wants to merge 1 commit intoPolusAI:masterfrom
ndonyapour:hotfix/flatfield-docker-bug
Open

Fix a bug in the Dockerfile for BaSIC flatfield estimation#608
ndonyapour wants to merge 1 commit intoPolusAI:masterfrom
ndonyapour:hotfix/flatfield-docker-bug

Conversation

@ndonyapour
Copy link
Copy Markdown
Member

Summary

Updates the BaSiC flatfield estimation tool Docker image and developer docs so local installs and container runs match how we ship the package (no committed uv.lock).

Changes

  • Dockerfile
    • Install liblzma-dev before building Python 3.12 from source so the stdlib lzma / _lzma module exists. This fixes import failures through basicpypoochlzma.
    • Run pip install --upgrade pip before pip install . to improve behavior for PEP 517 builds and git URL dependencies.
    • Drop the long commented os-release block (noise only).
  • README
    • Document installation and tests with uv pip install -e . / uv pip install -e ".[dev]" instead of uv sync, since we are not committing uv.lock for this package.
  • CWL
    • Rename flatfieldestimationusingbasicalgorithm..cwlflatfieldestimationusingbasicalgorithm.cwl (typo: double dot).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant