-
Notifications
You must be signed in to change notification settings - Fork 44
Add gen-idea skill to Codex installs #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zhaoxueyan1
wants to merge
2
commits into
PolyArch:dev
Choose a base branch
from
zhaoxueyan1:codex/gen-idea-codex-skill
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| # Finalize Phase | ||
|
|
||
| Codex review has passed. The implementation is complete and all acceptance criteria have been met. | ||
|
|
||
| You are now in the **Finalize Phase**. This is the opportunity to simplify and refactor the code before final completion. | ||
|
|
||
| ## Your Task | ||
|
|
||
| Use the Codex `code-simplifier:code-simplifier` agent if it is available in the current runtime. If that agent is not available, perform the same simplification pass directly in this session. | ||
|
|
||
| ## Constraints | ||
|
|
||
| These constraints are **non-negotiable**: | ||
|
|
||
| 1. **Must NOT change existing functionality** - All features must work exactly as before | ||
| 2. **Must NOT fail existing tests** - Run tests to verify nothing is broken | ||
| 3. **Must NOT introduce new bugs** - Be careful with refactoring | ||
| 4. **Only perform functionality-equivalent changes** - Simplification and cleanup only | ||
|
|
||
| ## Focus Areas | ||
|
|
||
| Focus on: | ||
| - Code that was recently added or modified | ||
| - Changes between branch from `{{BASE_BRANCH}}` to `{{START_BRANCH}}` | ||
| - Removing unnecessary complexity | ||
| - Improving readability and maintainability | ||
| - Consolidating duplicate code | ||
| - Simplifying control flow where possible | ||
| - Removing dead code or unused variables | ||
|
|
||
| ## Reference Files | ||
|
|
||
| - Original plan: @{{PLAN_FILE}} | ||
| - Goal tracker: @{{GOAL_TRACKER_FILE}} | ||
|
|
||
| ## Before Exiting | ||
|
|
||
| 1. Complete all `[mainline]` and `[blocking]` tasks | ||
| 2. `[queued]` tasks may remain only if they are documented as non-blocking follow-up work | ||
| 3. Commit your changes with a descriptive message | ||
| 4. Write your finalize summary to: **{{FINALIZE_SUMMARY_FILE}}** | ||
|
|
||
| Your summary should include: | ||
| - What simplifications were made | ||
| - Files modified during the Finalize Phase | ||
| - Confirmation that tests still pass | ||
| - Any notes about the refactoring decisions |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The manual install instructions say this awk step “matches the behavior of scripts/install-skill.sh”, but it only strips
user-invocable. The installer’sstrip_claude_specific_frontmatter()also removesdisable-model-invocationandhide-from-slash-command-tool, so manual installs will produce different SKILL.md frontmatter. Update this snippet to strip the same keys (or adjust the comment to reflect the actual behavior).