Skip to content

Conversation

@JonathanAmenechi
Copy link
Collaborator

@JonathanAmenechi JonathanAmenechi commented Aug 27, 2025

Note

Introduces a new on-chain fee collector plus deployment tooling and tests.

  • Adds Collector contract with admin-only withdrawFees(WithdrawOpts[]) that forwards withdrawals to IFeeModule
  • New Forge deploy script src/scripts/deploy/DeployCollector.s.sol creates Collector, assigns admin, renounces deployer, and verifies state
  • Adds shell wrapper scripts/deploy_collector.sh to broadcast deployment via forge script and output the deployed address
  • Adds tests src/test/Collector.t.sol and helpers to validate setup and successful multi-asset withdrawals

Written by Cursor Bugbot for commit a434e6e. This will update automatically on new commits. Configure here.

@JonathanAmenechi JonathanAmenechi marked this pull request as ready for review January 6, 2026 00:56
Copilot AI review requested due to automatic review settings January 6, 2026 00:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a Collector contract that serves as an intermediary for batch fee withdrawal operations. The contract receives admin authorization from the FeeModule and enables authorized admins to withdraw fees for multiple tokens in a single transaction.

  • Adds Collector contract with batch fee withdrawal capability
  • Implements test infrastructure with CollectorTestHelper for token minting and test setup
  • Provides comprehensive test coverage for the collector functionality

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/Collector.sol Core contract implementing batch fee withdrawal functionality with admin access control
src/test/dev/CollectorTestHelper.sol Test helper providing setup, token minting utilities, and withdraw options creation
src/test/Collector.t.sol Test suite validating collector setup and batch withdrawal operations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JonathanAmenechi JonathanAmenechi merged commit 1a3c31c into main Jan 6, 2026
4 checks passed
@JonathanAmenechi JonathanAmenechi deleted the fix/collector branch January 6, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants