Skip to content

Conversation

@gbl186
Copy link

@gbl186 gbl186 commented Jan 30, 2026

Added a basic CI build gate so broken dependency changes don’t sneak in.


Note

Medium Risk
Adds a new GitHub Actions build gate that will run on every PR/push; if npm run build is not defined or the build is flaky, it can start blocking merges unexpectedly.

Overview
Adds a new GitHub Actions workflow (.github/workflows/node-build.yml) that runs on pull requests and pushes to main/master, sets up Node 18, installs dependencies with npm ci, and executes npm run build as a CI build gate.

Written by Cursor Bugbot for commit 55d9bb5. This will update automatically on new commits. Configure here.

Added a basic CI build gate so broken dependency changes don’t sneak in.
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

- uses: actions/setup-node@v4
with:
node-version: 18
- run: npm ci
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI uses npm but project uses yarn

High Severity

The workflow uses npm ci but the project is configured to use yarn (evidenced by yarn.lock existing and no package-lock.json). The npm ci command will fail because it requires a package-lock.json file to function. This CI gate will never pass.

Fix in Cursor Fix in Web

with:
node-version: 18
- run: npm ci
- run: npm run build
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI calls nonexistent build script

High Severity

The workflow runs npm run build but there's no build script defined in package.json. The project only has specific build scripts like activity:build, pnl:build, fpmm:build, etc. This command will always fail with "missing script: build".

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant