Skip to content

Conversation

@juliankoh
Copy link
Contributor

@juliankoh juliankoh commented Jan 8, 2026

Split the single /rfq/data/quotes endpoint into two role-specific endpoints:

  • /rfq/data/requester/quotes - for requesters to see quotes on their requests
  • /rfq/data/quoter/quotes - for quoters to see quotes they've made

Overview

Description

Testing instructions

Types of changes

  • Refactor/enhancement
  • Bug fix/behavior correction
  • New feature
  • Breaking change
  • Other, additional

Notes

Status

  • Prefix PR title with [WIP] if necessary (changes not yet made).
  • Add tests to cover changes as needed.
  • Update documentation/changelog as needed.
  • Verify all tests run correctly in CI and pass.
  • Ready for review/merge.

Note

Introduces role-specific RFQ quote endpoints and corrects query param encoding.

  • Replaces GET_RFQ_QUOTES with GET_RFQ_REQUESTER_QUOTES and GET_RFQ_QUOTER_QUOTES; adds RfqClient.get_rfq_requester_quotes and get_rfq_quoter_quotes, and updates accept_rfq_quote/approve_rfq_order to use them
  • Switches query construction to urllib.parse.urlencode(..., doseq=True) and updates parse_rfq_requests_params/parse_rfq_quotes_params to keep arrays as lists (enabling repeated params like requestIds=id1&requestIds=id2); adds tests verifying this behavior
  • Uses urlencode for get_rfq_best_quote requestId
  • Examples: new examples/rfq_get_best_quote.py; examples/rfq_get_quotes.py now demonstrates requester/quoter views

Written by Cursor Bugbot for commit 52c91df. This will update automatically on new commits. Configure here.

Split the single /rfq/data/quotes endpoint into two role-specific endpoints:
- /rfq/data/requester/quotes - for requesters to see quotes on their requests
- /rfq/data/quoter/quotes - for quoters to see quotes they've made

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@juliankoh juliankoh requested a review from a team as a code owner January 8, 2026 07:42
@sahilgat02
Copy link
Contributor

Includes fixes for #219

@juliankoh juliankoh merged commit 2a991e2 into main Jan 10, 2026
5 checks passed
@juliankoh juliankoh deleted the j/rfq branch January 10, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants