This repository was archived by the owner on Dec 19, 2024. It is now read-only.
Ensure _applyIcon is not called multiple times. Fixes #120#121
Open
kevinpschaaf wants to merge 1 commit intomasterfrom
Open
Ensure _applyIcon is not called multiple times. Fixes #120#121kevinpschaaf wants to merge 1 commit intomasterfrom
kevinpschaaf wants to merge 1 commit intomasterfrom
Conversation
merlinnot
reviewed
Feb 1, 2018
| this.listen(window, 'iron-iconset-added', '_updateIcon'); | ||
| // Since _updateIcon can be called multiple times, make sure we | ||
| // avoid cloning the SVG if the icon & theme haven't changed | ||
| if (this._iconName !== this._lastIconName || |
There was a problem hiding this comment.
Can we introduce two constants right above for these inequality comparisons to increase readability? I’d suggest iconNameChanged and themeChanged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #120
Adds a dirty check on
iconandthemein_updateIconso that it avoids expensive work (cloning the SVG) if we've done it once for thisicon/themecombination.No test changes since it only affects performance, not correctness.