This repository was archived by the owner on Dec 19, 2024. It is now read-only.
Reflect icon property to attribute#69
Open
mgiuffrida wants to merge 1 commit intoPolymerElements:masterfrom
Open
Reflect icon property to attribute#69mgiuffrida wants to merge 1 commit intoPolymerElements:masterfrom
mgiuffrida wants to merge 1 commit intoPolymerElements:masterfrom
Conversation
Author
|
/cc @azakus @kevinpschaaf Would this have performance implications? |
stramel
approved these changes
Jul 26, 2017
It's nice to style `iron-icon`s based on which icon they show:
```
iron-icon[icon='done'] {
--iron-icon-fill-color: var(--google-green-500);
}
```
However, if the `icon` property is changed dynamically, the new style rules won't apply (even after `updateStyles`) because the attribute hasn't changed.
Author
|
rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's nice to style
iron-icons based on which icon they show:However, if the
iconproperty is changed dynamically, the new style rules won't apply (even afterupdateStyles) because the attribute hasn't changed.