This repository was archived by the owner on Dec 19, 2024. It is now read-only.
<img> element should inherit border-radius from its parent. Fix #90#91
Open
derfel wants to merge 1 commit intoPolymerElements:masterfrom
Open
<img> element should inherit border-radius from its parent. Fix #90#91derfel wants to merge 1 commit intoPolymerElements:masterfrom
derfel wants to merge 1 commit intoPolymerElements:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Author
|
I signed it! |
|
CLAs look good, thanks! |
|
Is there a road-map when the patch from @derfel will be merged into the upcoming release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if you want to add a specific mixin for the
imgelement, but I think in the meantime you could apply this little patch to let fix #90.If the
imgelement inherit border-radius from its parent there's no need for a new mixin and it works with both shady and shadow dom.For example:
iron-icon { --iron-icon: { border-radius: 50%; }; }