Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

Fix transition to use correct translateY for vertical alignment#87

Open
pik wants to merge 1 commit intoPolymerElements:masterfrom
pik:vertical-align-transition
Open

Fix transition to use correct translateY for vertical alignment#87
pik wants to merge 1 commit intoPolymerElements:masterfrom
pik:vertical-align-transition

Conversation

@pik
Copy link

@pik pik commented Oct 23, 2016

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@pik
Copy link
Author

pik commented Oct 24, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Member

@valdrinkoshi valdrinkoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pik could you please create an issue and refer to it in this PR?

Regarding the change, it would be enough to only update the styles and not introduce an observer. WDYT?

Also, it would be great to have a unit test for this new feature 👌

@apply(--paper-font-common-base);
}

:host(.vertical-align-top) {
Copy link
Member

@valdrinkoshi valdrinkoshi Apr 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could only add this new style, with a selector :host([vertical-align="top"])

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants