Fix transition to use correct translateY for vertical alignment#87
Fix transition to use correct translateY for vertical alignment#87pik wants to merge 1 commit intoPolymerElements:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
valdrinkoshi
left a comment
There was a problem hiding this comment.
@pik could you please create an issue and refer to it in this PR?
Regarding the change, it would be enough to only update the styles and not introduce an observer. WDYT?
Also, it would be great to have a unit test for this new feature 👌
| @apply(--paper-font-common-base); | ||
| } | ||
|
|
||
| :host(.vertical-align-top) { |
There was a problem hiding this comment.
you could only add this new style, with a selector :host([vertical-align="top"])
No description provided.