Change Fee Handler

[HenriqueNogara]

other

• Update CddHandler to decrease [Authorization.count] every time the any of the following extrinsics fail:
  • pallet-identity (accept_primary_key, join_identity_as_key, rotate_primary_key_to_secondary);
  • pallet-relayer (accept_paying_key)
  • pallet-multisig (accept_multisig_signer)

[Neopallium]

Looks good.

[Copilot]

Pull request overview

This PR updates Polymesh fee-handling and identity authorization retry behavior so that certain authorization-based extrinsics can have their retry counters decremented when the extrinsic fails.

Changes:

• Extends CddAndFeeDetails to track authorization IDs and decrement authorization retry counts on failed dispatch.
• Updates ChargeTransactionPayment to capture an auth_id in pre_dispatch and decrement on post_dispatch failure.
• Introduces a new MaxAuthRetries runtime constant and uses it to initialize Authorization.count, with get_non_expired_auth now requiring count > 0.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
primitives/src/traits.rs	Extends CddAndFeeDetails with payer-context helpers plus authorization-id/retry hooks; changes get_valid_payer signature to take AccountId by value.
pallets/transaction-payment/src/lib.rs	Tracks auth_id in signed extension Pre and decrements authorization retry count when dispatch fails.
pallets/runtime/tests/src/storage.rs	Updates test runtime to implement new CddAndFeeDetails methods and adds MaxAuthRetries.
pallets/runtime/tests/src/staking/mock.rs	Updates staking mock runtime to wire MaxAuthRetries and new CddAndFeeDetails signatures.
pallets/runtime/tests/src/relayer_test.rs	Updates test callsites for get_valid_payer signature change.
pallets/runtime/tests/src/identity_test.rs	Updates test callsites for get_valid_payer signature change.
pallets/runtime/tests/src/fee_details.rs	Updates test callsites for get_valid_payer signature change (clones/moves).
pallets/runtime/testnet/src/runtime.rs	Wires MaxAuthRetries into the runtime’s pallet_identity::Config.
pallets/runtime/mainnet/src/runtime.rs	Wires MaxAuthRetries into the runtime’s pallet_identity::Config.
pallets/runtime/develop/src/runtime.rs	Wires MaxAuthRetries into the runtime’s pallet_identity::Config.
pallets/runtime/common/src/fee_details.rs	Refactors CddHandler logic and implements authorization-id extraction + decrement hook.
pallets/identity/src/lib.rs	Adds new Config associated constant MaxAuthRetries.
pallets/identity/src/auth.rs	Initializes Authorization.count from MaxAuthRetries, requires count > 0 for get_non_expired_auth, and adds a decrement helper.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The doc comment for MaxAuthRetries is a copy of MaxGivenAuths and is misleading. It should describe that this constant controls the max number of retry attempts (i.e., how many failed attempts are allowed before an authorization is considered unusable), not the number of authorizations an identity can give.

Suggested change

	/// Maximum number of authorizations an identity can give.
	/// Maximum number of retry attempts allowed for an authorization
	/// before it is considered unusable.

[Copilot]

caller_acc_id is already owned here, so cloning it just to wrap in Some is unnecessary. Returning Ok(Some(caller_acc_id)) avoids an extra clone of AccountId.

Suggested change

	Ok(Some(caller_acc_id.clone()))
	Ok(Some(caller_acc_id))