-
Notifications
You must be signed in to change notification settings - Fork 0
[FIX] 관리자화면 시트뷰 개선과 디테일뷰로 이동되지않던 이슈 수정및 최적화 #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
ada6916
784e51e
ce6fbc8
0f64e6b
293075e
a0efe72
1b3b101
919402c
1cfdfb7
2368c6d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -97,6 +97,8 @@ final class AdminView: UIView { | |
| override init(frame: CGRect) { | ||
| super.init(frame: frame) | ||
| setupLayout() | ||
| tableView.backgroundView = UIView() | ||
| tableView.backgroundView?.isUserInteractionEnabled = true | ||
|
Comment on lines
+100
to
+101
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이거 바텀시트 뒤에 탭할때 사라지게하는 관련 코드인거같은데 맞다면 디자인시스템에 PPModal(UIViewController+.swift에 위치) 참고해서 적용해보시면 좋을것같아요
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. updateContainerHeight로 탭이 바뀔때마다 탭별로 컨테이너 영역의 높이가 동적으로 계산되게끔 작성했던것으로 기억ㅎ는데
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 아마 PPModal도 값을 주입하지 않으면 동적으로 modal의 높이를 계산하도록 내부적으로 구현되어있을텐데 한번 확인해보시면 좋을거같아요. @zzangzzangguy 내일까지 어려우시다면 일단 관리자페이지는 사용자 경험과는 크게 문제가 없으니 이대로 넘어가시고 추후 작업으로 이슈 빼두시면 좋을것 같습니다 |
||
| } | ||
|
|
||
| required init?(coder: NSCoder) { | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.