Skip to content

fix clang errors#21

Open
ludflu wants to merge 3 commits intoPortMidi:masterfrom
ludflu:compile-osx-fix-clang-errors
Open

fix clang errors#21
ludflu wants to merge 3 commits intoPortMidi:masterfrom
ludflu:compile-osx-fix-clang-errors

Conversation

@ludflu
Copy link
Copy Markdown

@ludflu ludflu commented Aug 4, 2024

  • fix problems with casting unsigned ints to (void *) pointers
  • these changes allow us to compile PortMidi for OSX again.

Copy link
Copy Markdown
Member

@OlivierSohn OlivierSohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there are lots of formatting changes but the code seems more readable now.

@dpwiz
Copy link
Copy Markdown

dpwiz commented Aug 6, 2024

Is it possible to split commits into formatting and then actual fixing?

@ludflu
Copy link
Copy Markdown
Author

ludflu commented Aug 6, 2024

yes, i'd be happy to do that

@ludflu
Copy link
Copy Markdown
Author

ludflu commented Aug 18, 2024

Is there anything else I can do to help move this along?

@OlivierSohn
Copy link
Copy Markdown
Member

I am not familiar with this code at all, but after looking at how the descriptor field is used in the code base, the changes seem to be reasonable.

I think I would prefer if the macro for casting is removed and casts are in the code directly.

@dpwiz are you more familiar with this code base, what do you think?

@dpwiz
Copy link
Copy Markdown

dpwiz commented Sep 5, 2024

There were a few more warnings about pointers, so... #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants