Closed
Conversation
Contributor
|
Thanks! I had to get Claude to explain CMake scope rules to understand this. That seems like a real design flaw in CMake. Rather than pulling these changes, I added comments and fixes locally because without comments or a deeper understanding of CMake, the logic seems really strange. Maybe that's why it got broken to begin with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting an alternative name for the static library via PM_STATIC_LIB_NAME has been broken in commit e878378.
This change fixes it by setting PM_ACTUAL_LIB_NAME in the current scope AND the parent scope.
It can be tested like this:
This should print
PortMidi Library name: testand producelibtest.a.